PHP - mySQL db keeps ingoring 1st part of my query

Question

Hello i wrote some PHP code:

$number = $_POST['number'];
$start = $_POST['start'];
$end = $_POST['end'];
$user_name = $_POST['user_name'];
$phone = $_POST['phone'];

$validation_query = "SELECT * FROM `rezerwacje_miejsc` WHERE 
`NR_MIEJSCA`='$number' AND `START` BETWEEN '$start' AND '$end' OR `KONIEC` 
BETWEEN '$start' AND '$end';";

But every time SQL is returning any value if is between but ignores number - I've tried to use '$number', $number or even wrote number manually. Still no effect any ideas?

try to use " + $number + " Did you try echoing and manually executing the sql query? — ikdekker, Mar 12 '18 at 10:26
can you please try by adding braces to your query like "SELECT * FROM `rezerwacje_miejsc` WHERE `NR_MIEJSCA`='$number' AND (`START` BETWEEN ('$start' AND '$end') OR `KONIEC` BETWEEN ('$start' AND '$end'));" — Jigar Shah, Mar 12 '18 at 10:27
it finds all records that BETWEEN values are true no matter what the number is - it is just like if there was no `NR_MIEJSCA`=$number only further BETWEEN — Luke_Nuke, Mar 12 '18 at 10:29
the way he put it, it seemed like it may have been interpreted as a string literal. Closing the string adding a var with concatenation could make it more legible too imo — ikdekker, Mar 12 '18 at 10:33
`.` is concatenation operator for PHP and `+` is for Javascript — Jigar Shah, Mar 12 '18 at 10:35

score 2 · Accepted Answer · answered Mar 12 '18 at 10:31

2

This is beacause of your "AND". I will short the SQL a little bit to explain it better:

SELECT * FROM table WHERE condition1 AND condition2 OR condition3

This will simply link the three conditions together. So if your Condition3 is true, Condition1 & Condition2 doesn't matter.

I think if you use brackets it could work:

 SELECT * FROM table WHERE condition1 AND (condition2 OR condition3)

Hope this helps you

answered Mar 12 '18 at 10:31

IX33U

85
4

That was exactly my issue. Thanks I'll rember this! :) – Luke_Nuke Mar 12 '18 at 10:45

score 1 · Answer 2 · answered Mar 12 '18 at 10:31

Try this.

$number = (int)$_POST['number'];

$validation_query = "SELECT * FROM `rezerwacje_miejsc` WHERE 
`NR_MIEJSCA`=".$number." AND (`START` BETWEEN ('$start' AND '$end') OR `KONIEC` 
BETWEEN ('$start' AND '$end'))";

You need to pass the integer value. Secondly you need to () so it will read the query to satisfied both conditions NR_MIEJSCA=".$number." And START BETWEEN ('$start' AND '$end') OR KONIEC BETWEEN ('$start' AND '$end'))" but OR condition on the second part.

Hope this helps.

Thanks.

PHP - mySQL db keeps ingoring 1st part of my query

2 Answers2