Assigning a random number to it's respected place with java.util.random 1000 times

Question

I am trying to assign a number 1-10 to two variables. If the number is greater than max then update max with that number, if the number is less than min, then update min with. All the while updating the total with whatever number gets generated. I thought I had it correct but whenever it generates. Then at the end I must average it. The number isn't random and get's stuck on the same few numbers. Not sure what I have wrong.

package java_programming;
import java.util.Random;

public class Jp{
    public static void main(String[] args){
        //The Power Operation
        double power = Math.pow(5.0,3.0);

        //The Square Root Operation
        double root = Math.sqrt(12.0);

        //The Max Operation
        double Maxi = Math.max(23.4, 23.5);

        //The Min Operation
        double Mini = Math.min(23.4, 23.5);

        //The Random Opeartion
        double rand = Math.random();

        System.out.println("Results");
        System.out.println("Math.pow = " + power);
        System.out.println("Math.sqrt = " + root);
        System.out.println("Math.max = " + Maxi);
        System.out.println("Math.min = " + Mini);

        System.out.println("Math.random = " + rand);
        Jp rs = new Jp();
        System.out.println("Min value");

        rs.randomStudy();
    }

    public void randomStudy(){
        int total = 0;
        int max = -1;
        int min = 11;
        int iterations = 1000;
        Random ran = new Random();
        for(int i = 0; i < iterations; i++){
            int count = ran.nextInt(10);
            min = Math.min(count, min);
            max = Math.max(count, max);
            total += count;
        }
        System.out.println("Result of max: " + max);
        System.out.println("Result of min: " + min);
        System.out.println("Average: " + (1.0 * total / iterations));
    }
}

Answer 1

Looking only at randomStudy():

public void randomStudy()
{
    int total = 0;
    int max = -1;
    int min = 11;
    int i = 0;
    Random ran = new Random();
    while (i < 1001)
    {
        for(int count = 1; count<=10;count++)
            count = ran.nextInt(11);

        if(total < min)
            min = total;
        if(total>max)
            max = total;

        System.out.println("Result of max: " + max);
        System.out.println("Result of min: " + min);
        double average = total/1000;
        System.out.println("Average: " + average);
        i++;
    }
}

• Initializes variables: total, max, min, i, ran
• Loops 1000 times
  • Loops 10 times
    • sets count to [0, 10]
  • Checks and sets min/max
  • Prints min/max/average

---

• Using a while loop can be done with a counter, but it's usually done with a for loop
• Looping until you get a random number >= 10 doesn't make much sense, since you just want a random number
• min/max are probably expected to be min/max of the random count, not of the total (and it's clearer to use Math.min/max)
• Calculating the average should be done with double division, not with integer division
• Normally when printing results, one expects overall results, not at each stage of calculation

Updated method:

public void randomStudy()
{
    int total = 0;
    int max = -1;
    int min = 11;
    int iterations = 1000;
    Random ran = new Random();
    for(int i = 0; i < iterations; i++)
    {
        int count = ran.nextInt(11);
        min = Math.min(count, min);
        max = Math.max(count, max);
        total += count;
    }

    System.out.println("Result of max: " + max);
    System.out.println("Result of min: " + min);
    System.out.println("Average: " + (1.0 * total / iterations));
}

---

With the questions edits:

[...]
while(i < 1001)
{
    for(int j = 0; j < 1000; j++)
    [...]

That will loop 1000*1000 (1000000) times, which may be a bit more than what you're trying to do

---

To get random numbers [1, 10] instead of [0, 10], use ran.nextInt(10) + 1 instead (How do I generate random integers within a specific range in Java?)