How do I add WHERE hide != 1 to my select statement?

Question

$raw_results = mysql_query("SELECT * FROM system_passwords 
    WHERE hide != 1 AND (`id` LIKE '%".$query."%') 
    OR (`system_name` LIKE '%".$query."%') 
    OR (`database_name` LIKE '%".$query."%') 
    OR (`username` LIKE '%".$query."%') 
    OR (`password` LIKE '%".$query."%') 
    OR (`notes` LIKE '%".$query."%') 
    OR (`additional_info` LIKE '%".$query."%')") or die(mysql_error());

How or where do I add hide != 1 into this?

It doesn't work where it is so I was asking where it should go, or how to write it. — deansmith, Aug 20 '15 at 20:58
Doesn't work as in you get an error or it doesn't give you the results you expect? — chris85, Aug 20 '15 at 21:00
It doesn't ignore the rows with entries in column "hide" with value 1 — deansmith, Aug 20 '15 at 21:02

score 2 · Accepted Answer · edited May 23 '17 at 10:26

You have to group the ors together. As is your query runs as

WHERE hide != 1 AND (`id` LIKE '%".$query."%')

or

(system_name LIKE '%".$query."%')

or etc.

This should group the values as you expect.

SELECT * FROM system_passwords 
WHERE (
        (`id` LIKE '%".$query."%') OR 
        (`system_name` LIKE '%".$query."%') OR 
        (`database_name` LIKE '%".$query."%') OR 
        (`username` LIKE '%".$query."%') OR 
        (`password` LIKE '%".$query."%') OR 
        (`notes` LIKE '%".$query."%') OR 
        (`additional_info` LIKE '%".$query."%')
    ) and hide != 1

You also should switch over to PDO or mysqli so you can use prepared statements. This may open you to SQL injections; not knowing what $query can't say for certain..

Additional information: Mysql or/and precedence?

score 1 · Answer 2 · answered Aug 20 '15 at 20:57

1

It is in the right place, but this is less ambiguous logically WHERE hide != 1 AND ([a] OR [b] OR [c])

answered Aug 20 '15 at 20:57

Uueerdo

15,723
1
16
21

How do I add WHERE hide != 1 to my select statement?

2 Answers2