I only know a few examples of pro-$p$ groups.
- Of course the $p$-adics $\mathbf{Z}_p$, and any finite $p$-group.
- Congruence subgroups of $\text{GL}_n(\mathbf{Z}_p)$: e.g. $\Gamma_1:=\{g\in \text{SL}_n(\mathbf{Z}_p) : g\equiv \text{id} \, (\text{mod } p)\}$.
- The pro-$p$ completion of any topological group, for example the free pro-$p$ group $\widehat{F}_p(X)$ on a set $X$ is the pro-$p$ completion of the discrete free group on $X$.
I'm not quite convinced that pro-$p$ groups are ubiquitous. For example when you first learn about solvable groups, it might not be clear that they are common. But if you view them as groups which can be built up as extension by abelian groups then suddenly you nod and say "Yeah I guess I could make one if I wanted to."
(I suppose you could say the same thing about pro-$p$ groups: if you really wanted to, you could sit down and make an inverse system of finite $p$-groups.)
On the other hand I don't feel that the definition of a pro-$p$ group is contrived, but I can't justify this without having accessible examples. I have no idea how to construct counterexamples. My main issues are here:
- Find non-powerful pro-$p$ groups, one finite and one infinite.
- Find a non-nilpotent pro-$p$ group.
- Find a (finitely-generated) pro-$p$ group of infinite rank.
- Find a finite rank pro-$p$ group with an infinitely-generated subgroup.
Do people usually use generators and relations to construct such groups?